-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add json marshaler interface to log's entry interface #58
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #58 +/- ##
==========================================
- Coverage 68.87% 68.80% -0.08%
==========================================
Files 23 23
Lines 1825 1827 +2
==========================================
Hits 1257 1257
- Misses 365 367 +2
Partials 203 203
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@gfanton , these changes seem harmless, but are they being used anywhere? |
@jefft0 to do a local replace and see if we can still compile dependant repos like weshnet and berty. Check if the changes in this PR force those repos to implement json marshalling. |
Signed-off-by: gfanton <[email protected]>
66d5c71
to
1efd55a
Compare
I did a force push of of rebasing this PR to the latest master. |
I confirm that we can build go-orbit-db, weshnet and berty with a local go.mod replace for this PR. But still have the "stack overflow" error shown above. |
@gfanton will ask if it's OK to merge this. |
Closing. @gfanton says "doesn't think it will be useful anyways and can probably introduce some problems." |
No description provided.